tor-browser

commit 00eca1319bc3a2f8f5e50e92bde96a76739bd007
parent bd2ee9467d71dcede62051cb3819e1bea90ff301
Author: Julie De Lorenzo <jdelorenzo@mozilla.com>
Date:   Mon, 27 Oct 2025 22:03:21 +0000

Bug 1983110: Rename row height variable in TabsTrayBanner and make Dp type r=007,android-reviewers

Differential Revision: https://phabricator.services.mozilla.com/D268766

Diffstat:
M
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/ui/banner/TabsTrayBanner.kt
 | 
12
++++++------

1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/ui/banner/TabsTrayBanner.kt b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tabstray/ui/banner/TabsTrayBanner.kt
@@ -63,7 +63,7 @@ import kotlin.math.max
 import mozilla.components.ui.icons.R as iconsR
 
 private const val TAB_COUNT_SHOW_CFR = 6
-private const val ROW_HEIGHT_DP = 48
+private val RowHeight = 48.dp
 private val TabIndicatorRoundedCornerDp = 100.dp
 
 /**
@@ -273,7 +273,7 @@ private fun TabPageBanner(
                         .semantics {
                             contentDescription = privateTabDescription
                         }
-                        .height(ROW_HEIGHT_DP.dp),
+                        .height(RowHeight),
                     unselectedContentColor = inactiveColor,
                 ) {
                     Text(
@@ -290,7 +290,7 @@ private fun TabPageBanner(
                         .semantics {
                             contentDescription = normalTabDescription
                         }
-                        .height(ROW_HEIGHT_DP.dp),
+                        .height(RowHeight),
                     unselectedContentColor = inactiveColor,
                 ) {
                     Text(
@@ -307,7 +307,7 @@ private fun TabPageBanner(
                         .semantics {
                             contentDescription = syncedTabDescription
                         }
-                        .height(ROW_HEIGHT_DP.dp),
+                        .height(RowHeight),
                     unselectedContentColor = inactiveColor,
                 ) {
                     Text(
@@ -317,7 +317,7 @@ private fun TabPageBanner(
                 }
             }
         },
-        expandedHeight = ROW_HEIGHT_DP.dp,
+        expandedHeight = RowHeight,
         colors = TopAppBarDefaults.centerAlignedTopAppBarColors(
             scrolledContainerColor = MaterialTheme.colorScheme.surfaceContainerHigh,
         ),
@@ -430,7 +430,7 @@ private fun MultiSelectBanner(
                 )
             }
         },
-        expandedHeight = ROW_HEIGHT_DP.dp,
+        expandedHeight = RowHeight,
         colors = TopAppBarDefaults.topAppBarColors(
             containerColor = MaterialTheme.colorScheme.surfaceContainerHigh,
             actionIconContentColor = buttonTint,