neovim

commit f6cc604af2a4d95ec9bcaa5bee705cec2e06d541
parent d0f8f76224f501d919ba6c8a5cd717de76903b34
Author: Sean Dewar <seandewar@users.noreply.github.com>
Date:   Sat, 26 Feb 2022 13:27:43 +0000

fix(api): convert blob to NUL-terminated API string

Looks like I did an oopsie; although API strings carry a size field, they should
still be usable as C-strings! (even though they may contain embedded NULs)

Diffstat:
M
src/nvim/api/private/converter.c
 | 
2
+-
M
test/functional/lua/api_spec.lua
 | 
7
+++++++

2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/nvim/api/private/converter.c b/src/nvim/api/private/converter.c
@@ -57,7 +57,7 @@ typedef struct {
     const size_t len_ = (size_t)(len); \
     const blob_T *const blob_ = (blob); \
     kvi_push(edata->stack, STRING_OBJ(((String) { \
-      .data = len_ != 0 ? xmemdup(blob_->bv_ga.ga_data, len_) : NULL, \
+      .data = len_ != 0 ? xmemdupz(blob_->bv_ga.ga_data, len_) : xstrdup(""), \
       .size = len_ \
     }))); \
   } while (0)
diff --git a/test/functional/lua/api_spec.lua b/test/functional/lua/api_spec.lua
@@ -102,6 +102,13 @@ describe('luaeval(vim.api.…)', function()
     eq(false, funcs.luaeval('vim.api.nvim__id(false)'))
     eq(NIL, funcs.luaeval('vim.api.nvim__id(nil)'))
 
+    -- API strings from Blobs can work as NUL-terminated C strings
+    eq('Vim(call):E5555: API call: Vim:E15: Invalid expression: ',
+       exc_exec('call nvim_eval(v:_null_blob)'))
+    eq('Vim(call):E5555: API call: Vim:E15: Invalid expression: ',
+       exc_exec('call nvim_eval(0z)'))
+    eq(1, eval('nvim_eval(0z31)'))
+
     eq(0, eval([[type(luaeval('vim.api.nvim__id(1)'))]]))
     eq(1, eval([[type(luaeval('vim.api.nvim__id("1")'))]]))
     eq(3, eval([[type(luaeval('vim.api.nvim__id({1})'))]]))