commit d4a65dad23b910ad0e5f44cc1720e8bd82bd749b
parent fb1740521aad48ba7ebd797042d869e3d649b91a
Author: zeertzjq <zeertzjq@outlook.com>
Date: Sat, 25 Jan 2025 23:03:43 +0800
vim-patch:9.1.1052: tests: off-by-one error in CheckCWD in test_debugger.vim (#32202)
Problem: tests: off-by-one error in CheckCWD in test_debugger.vim
Solution: Fix off-by-one in CheckCWD leading to local tests failure
(Yee Cheng Chin)
Vim's test_debugger's Test_debug_backtrace_level test will fail if you
happen to run it in a Vim repository with full path of directory being
exactly 29 characters (e.g. `/Users/bob/developing/src/vim`). The test
does term dump comparison and the printout will overflow if the CWD is
too long. It does have a function to skip to test if it detects that but
it's off by one leading to this one situation where it will fail.
The reason why the logic didn't account for this is that Vim's message
printing will overflow the text if it prints a message at exactly the
width of the terminal. This could be considered a bug / quirk but that
will be another issue.
closes: vim/vim#16517
https://github.com/vim/vim/commit/3acfbb4b548f4b1659ff1368a1b626cdd263acbe
Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>
Diffstat:
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/test/old/testdir/test_debugger.vim b/test/old/testdir/test_debugger.vim
@@ -6,10 +6,11 @@ source check.vim
func CheckCWD()
" Check that the longer lines don't wrap due to the length of the script name
- " in cwd
+ " in cwd. Need to subtract by 1 since Vim will still wrap the message if it
+ " just fits.
let script_len = len( getcwd() .. '/Xtest1.vim' )
let longest_line = len( 'Breakpoint in "" line 1' )
- if script_len > ( 75 - longest_line )
+ if script_len > ( 75 - longest_line - 1 )
throw 'Skipped: Your CWD has too many characters'
endif
endfunc
