neovim

commit b4039ec0b026938051061ee93618a0d14e54581c
parent b6befc7b0333ede9f44df3527f304729fdfe8426
Author: zeertzjq <zeertzjq@outlook.com>
Date:   Tue, 27 Jan 2026 12:45:49 +0800

fix(terminal): don't allow b:term_title watcher to delete buffer

Diffstat:
M
src/nvim/terminal.c
 | 
2
++
M
test/functional/terminal/buffer_spec.lua
 | 
10
++++++++++

2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/src/nvim/terminal.c b/src/nvim/terminal.c
@@ -1416,6 +1416,7 @@ static void buf_set_term_title(buf_T *buf, const char *title, size_t len)
   }
 
   Error err = ERROR_INIT;
+  buf->b_locked++;
   dict_set_var(buf->b_vars,
                STATIC_CSTR_AS_STRING("term_title"),
                STRING_OBJ(((String){ .data = (char *)title, .size = len })),
@@ -1423,6 +1424,7 @@ static void buf_set_term_title(buf_T *buf, const char *title, size_t len)
                false,
                NULL,
                &err);
+  buf->b_locked--;
   api_clear_error(&err);
   status_redraw_buf(buf);
 }
diff --git a/test/functional/terminal/buffer_spec.lua b/test/functional/terminal/buffer_spec.lua
@@ -1134,6 +1134,16 @@ describe(':terminal buffer', function()
     feed([[<C-\><C-N>]])
     eq({ mode = 'nt', blocking = false }, api.nvim_get_mode())
   end)
+
+  it('does not allow b:term_title watcher to delete buffer', function()
+    local chan = api.nvim_open_term(0, {})
+    api.nvim_chan_send(chan, '\027]2;SOME_TITLE\007')
+    eq('SOME_TITLE', api.nvim_buf_get_var(0, 'term_title'))
+    command([[call dictwatcheradd(b:, 'term_title', {-> execute('bwipe!')})]])
+    api.nvim_chan_send(chan, '\027]2;OTHER_TITLE\007')
+    eq('OTHER_TITLE', api.nvim_buf_get_var(0, 'term_title'))
+    matches('^E937: ', api.nvim_get_vvar('errmsg'))
+  end)
 end)
 
 describe('on_lines does not emit out-of-bounds line indexes when', function()