neovim

Neovim text editor
git clone https://git.dasho.dev/neovim.git
Log | Files | Refs | README

commit acb99b8a6572d8ea8d917955a653945550923be0
parent 1cb1cfead017df79aa590d1d297b116a85cb31c0
Author: Shadman <shadmansaleh3@gmail.com>
Date:   Tue,  9 Sep 2025 04:09:48 +0600

fix(prompt_buffer): plugins can't set `':` mark #35624

Problem:
Currently, prompt_buffer manages `:` mark by itself and exposes it
read-only mark. However when it fails there can be no mitigation made
by plugins. The `:` mark should act like a regular marks and be
modifiable.

Solution:
Allow plugins to set `:` mark.
Diffstat:
Msrc/nvim/mark.c | 8++++++--
Mtest/functional/legacy/prompt_buffer_spec.lua | 6++++++
2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/nvim/mark.c b/src/nvim/mark.c @@ -146,6 +146,11 @@ int setmark_pos(int c, pos_T *pos, int fnum, fmarkv_T *view_pt) return OK; } + if (c == ':' && bt_prompt(buf)) { + RESET_FMARK(&buf->b_prompt_start, *pos, buf->b_fnum, view); + return OK; + } + if (ASCII_ISLOWER(c)) { i = c - 'a'; RESET_FMARK(buf->b_namedm + i, *pos, fnum, view); @@ -1720,8 +1725,7 @@ bool mark_set_local(const char name, buf_T *const buf, const fmark_T fm, const b } else if (name == '^') { fm_tgt = &(buf->b_last_insert); } else if (name == ':') { - // Readonly mark for prompt buffer. Can't be edited on user side. - return false; + fm_tgt = &(buf->b_prompt_start); } else if (name == '.') { fm_tgt = &(buf->b_last_change); } else { diff --git a/test/functional/legacy/prompt_buffer_spec.lua b/test/functional/legacy/prompt_buffer_spec.lua @@ -622,6 +622,12 @@ describe('prompt buffer', function() -- ': mark is only available in prompt buffer. source('set buftype=') eq("Invalid mark name: ':'", t.pcall_err(api.nvim_buf_get_mark, 0, ':')) + + -- mark can be moved + source('set buftype=prompt') + eq({ 11, 1 }, api.nvim_buf_get_mark(0, ':')) + eq(true, api.nvim_buf_set_mark(0, ':', 1, 1, {})) + eq({ 1, 1 }, api.nvim_buf_get_mark(0, ':')) end) describe('prompt_getinput', function()