neovim

commit aa492127311692a576d308db3afbd3bba0fead00
parent c0840087c83175267667a355131d4dffccfd8ff5
Author: zeertzjq <zeertzjq@outlook.com>
Date:   Sat,  3 Dec 2022 13:34:25 +0800

vim-patch:9.0.0322: crash when no errors and 'quickfixtextfunc' is set (#21269)

Problem:    Crash when no errors and 'quickfixtextfunc' is set.
Solution:   Do not handle errors if there aren't any.

https://github.com/vim/vim/commit/4f1b083be43f351bc107541e7b0c9655a5d2c0bb

Co-authored-by: Bram Moolenaar <Bram@vim.org>
Diffstat:
M
src/nvim/quickfix.c
 | 
2
+-
M
src/nvim/testdir/test_quickfix.vim
 | 
16
++++++++++++++++

2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/src/nvim/quickfix.c b/src/nvim/quickfix.c
@@ -4076,7 +4076,7 @@ static void qf_fill_buffer(qf_list_T *qfl, buf_T *buf, qfline_T *old_last, int q
   }
 
   // Check if there is anything to display
-  if (qfl != NULL) {
+  if (qfl != NULL && qfl->qf_start != NULL) {
     char dirname[MAXPATHL];
 
     *dirname = NUL;
diff --git a/src/nvim/testdir/test_quickfix.vim b/src/nvim/testdir/test_quickfix.vim
@@ -3932,6 +3932,22 @@ func Xgetlist_empty_tests(cchar)
   endif
 endfunc
 
+func Test_empty_list_quickfixtextfunc()
+  " This was crashing.  Can only reproduce by running it in a separate Vim
+  " instance.
+  let lines =<< trim END
+      func s:Func(o)
+              cgetexpr '0'
+      endfunc
+      cope
+      let &quickfixtextfunc = 's:Func'
+      cgetfile [ex
+  END
+  call writefile(lines, 'Xquickfixtextfunc')
+  call RunVim([], [], '-e -s -S Xquickfixtextfunc -c qa')
+  call delete('Xquickfixtextfunc')
+endfunc
+
 func Test_getqflist()
   call Xgetlist_empty_tests('c')
   call Xgetlist_empty_tests('l')