neovim

commit a84b454ebe661981f292ee8fc73be4f9cd3a5884
parent debad0020c06180e275e158995aa5757ed56ae2d
Author: luukvbaal <luukvbaal@gmail.com>
Date:   Sun, 19 Nov 2023 00:58:33 +0100

fix(sign): do not error when defining sign without attributes (#26106)

Fix https://github.com/airblade/vim-gitgutter/issues/875
Diffstat:
M
src/nvim/sign.c
 | 
11
+++++------

1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/nvim/sign.c b/src/nvim/sign.c
@@ -578,11 +578,13 @@ static void sign_define_cmd(char *name, char *cmdline)
   char *texthl = NULL;
   char *culhl = NULL;
   char *numhl = NULL;
-  int failed = false;
 
   // set values for a defined sign.
   while (true) {
     char *arg = skipwhite(cmdline);
+    if (*arg == NUL) {
+      break;
+    }
     cmdline = skiptowhite_esc(arg);
     if (strncmp(arg, "icon=", 5) == 0) {
       icon = arg + 5;
@@ -598,8 +600,7 @@ static void sign_define_cmd(char *name, char *cmdline)
       numhl = arg + 6;
     } else {
       semsg(_(e_invarg2), arg);
-      failed = true;
-      break;
+      return;
     }
     if (*cmdline == NUL) {
       break;
@@ -607,9 +608,7 @@ static void sign_define_cmd(char *name, char *cmdline)
     *cmdline++ = NUL;
   }
 
-  if (!failed) {
-    sign_define_by_name(name, icon, text, linehl, texthl, culhl, numhl);
-  }
+  sign_define_by_name(name, icon, text, linehl, texthl, culhl, numhl);
 }
 
 /// ":sign place" command