neovim

commit a41703d107da4479635f8c9ebcd14409e6a7d648
parent ec89c5b261642e7af2d3f5f975f031c7ec1d0db2
Author: Evgeni Chasnovski <evgeni.chasnovski@gmail.com>
Date:   Sat, 13 Sep 2025 23:32:09 +0300

feat(pack): confirm "Always" to install all plugins #35733

Problem: First clean start with config containing multiple
  `vim.pack.add()` calls requires to explicitly confirm each one.
  Although usually a rare occurrence, it still might be tedious.

Solution: Add a third choice during installation confirmation that
  approves current and all next installs within current session. It is
  reset after session restart.
Diffstat:
M
runtime/lua/vim/pack.lua
 | 
11
+++++++++--
M
test/functional/plugin/pack_spec.lua
 | 
60
+++++++++++++++++++++++++++++++++++++++++++-----------------

2 files changed, 52 insertions(+), 19 deletions(-)
diff --git a/runtime/lua/vim/pack.lua b/runtime/lua/vim/pack.lua
@@ -416,18 +416,25 @@ local function run_list(plug_list, f, progress_action)
   report_progress('end', 100, '(%d/%d)', #funs, #funs)
 end
 
+local confirm_all = false
+
 --- @param plug_list vim.pack.Plug[]
 --- @return boolean
 local function confirm_install(plug_list)
+  if confirm_all then
+    return true
+  end
+
   local src = {} --- @type string[]
   for _, p in ipairs(plug_list) do
     src[#src + 1] = p.spec.src
   end
   local src_text = table.concat(src, '\n')
   local confirm_msg = ('These plugins will be installed:\n\n%s\n'):format(src_text)
-  local res = vim.fn.confirm(confirm_msg, 'Proceed? &Yes\n&No', 1, 'Question') == 1
+  local res = vim.fn.confirm(confirm_msg, 'Proceed? &Yes\n&No\n&Always', 1, 'Question')
+  confirm_all = res == 3
   vim.cmd.redraw()
-  return res
+  return res ~= 2
 end
 
 --- @param tags string[]
diff --git a/test/functional/plugin/pack_spec.lua b/test/functional/plugin/pack_spec.lua
@@ -294,6 +294,18 @@ local function validate_progress_report(action, step_names)
   eq(final_step, echo_log[n_steps + 2])
 end
 
+local function mock_confirm(output_value)
+  exec_lua(function()
+    _G.confirm_log = _G.confirm_log or {}
+
+    ---@diagnostic disable-next-line: duplicate-set-field
+    vim.fn.confirm = function(...)
+      table.insert(_G.confirm_log, { ... })
+      return output_value
+    end
+  end)
+end
+
 local function is_jit()
   return exec_lua('return package.loaded.jit ~= nil')
 end
@@ -351,14 +363,8 @@ describe('vim.pack', function()
     end)
 
     it('asks for installation confirmation', function()
-      exec_lua(function()
-        ---@diagnostic disable-next-line: duplicate-set-field
-        vim.fn.confirm = function(...)
-          _G.confirm_args = { ... }
-          -- Do not confirm installation to see what happens
-          return 0
-        end
-      end)
+      -- Do not confirm installation to see what happens
+      mock_confirm(2)
 
       local err = pcall_err(exec_lua, function()
         vim.pack.add({ repos_src.basic })
@@ -368,25 +374,45 @@ describe('vim.pack', function()
       eq(false, exec_lua('return pcall(require, "basic")'))
 
       local confirm_msg = 'These plugins will be installed:\n\n' .. repos_src.basic .. '\n'
-      eq({ confirm_msg, 'Proceed? &Yes\n&No', 1, 'Question' }, exec_lua('return _G.confirm_args'))
+      local ref_log = { { confirm_msg, 'Proceed? &Yes\n&No\n&Always', 1, 'Question' } }
+      eq(ref_log, exec_lua('return _G.confirm_log'))
     end)
 
     it('respects `opts.confirm`', function()
+      mock_confirm(1)
       exec_lua(function()
-        _G.confirm_used = false
-        ---@diagnostic disable-next-line: duplicate-set-field
-        vim.fn.confirm = function()
-          _G.confirm_used = true
-          return 1
-        end
-
         vim.pack.add({ repos_src.basic }, { confirm = false })
       end)
 
-      eq(false, exec_lua('return _G.confirm_used'))
+      eq(0, exec_lua('return #_G.confirm_log'))
       eq('basic main', exec_lua('return require("basic")'))
     end)
 
+    it('can always confirm in current session', function()
+      mock_confirm(3)
+
+      exec_lua(function()
+        vim.pack.add({ repos_src.basic })
+      end)
+      eq(1, exec_lua('return #_G.confirm_log'))
+      eq('basic main', exec_lua('return require("basic")'))
+
+      exec_lua(function()
+        vim.pack.add({ repos_src.defbranch })
+      end)
+      eq(1, exec_lua('return #_G.confirm_log'))
+      eq('defbranch dev', exec_lua('return require("defbranch")'))
+
+      -- Should still ask in next session
+      n.clear()
+      mock_confirm(3)
+      exec_lua(function()
+        vim.pack.add({ repos_src.plugindirs })
+      end)
+      eq(1, exec_lua('return #_G.confirm_log'))
+      eq('plugindirs main', exec_lua('return require("plugindirs")'))
+    end)
+
     it('installs at proper version', function()
       local out = exec_lua(function()
         vim.pack.add({