commit 994444571ee75b30be4c7581a9afcc95f427c255
parent cabf82be5a6f5a398c29c2bdf6b27af30853730a
Author: Justin M. Keyes <justinkz@gmail.com>
Date: Wed, 14 Jan 2026 19:25:11 -0500
test: remove non-actionable tests from "pending" list #37384
Problem:
`t.skip()` adds to the "pending" list. If there is no path to fixing
a pending test, it adds noise to the pending list.
Solution:
Return early instead of using `t.skip()`.
Diffstat:
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/test/functional/core/job_spec.lua b/test/functional/core/job_spec.lua
@@ -286,7 +286,9 @@ describe('jobs', function()
end)
it('error on non-executable `cwd`', function()
- skip(is_os('win'), 'Not applicable for Windows')
+ if is_os('win') then
+ return -- Not applicable for Windows.
+ end
local dir = 'Xtest_not_executable_dir'
mkdir(dir)
@@ -1341,9 +1343,10 @@ describe('jobs', function()
end)
it('uses real pipes for stdin/stdout #35984', function()
- if skip(is_os('win'), 'Not applicable for Windows') then
- return
+ if is_os('win') then
+ return -- Not applicable for Windows.
end
+
-- this fails on linux if we used socketpair() for stdin and stdout,
-- which libuv does if you ask to create stdio streams for you
local val = exec_lua(function()