neovim

commit 85cb0b0ddc59cd1b3a911e5b4a358e5404c1d0d8
parent 0760d986800ada048459196914dfa51213daa9a6
Author: Evgeni Chasnovski <evgeni.chasnovski@gmail.com>
Date:   Thu, 22 Feb 2024 21:54:21 +0200

fix(defaults): make terminal autoclose not block other events (#27581)

Problem: When terminal is autocloses, it blocks other events, like
  `BufEnter`.

Solution: Use `nested = true`.
Diffstat:
M
runtime/lua/vim/_defaults.lua
 | 
14
++++++++------
M
test/functional/options/defaults_spec.lua
 | 
19
+++++++++++++++++++

2 files changed, 27 insertions(+), 6 deletions(-)
diff --git a/runtime/lua/vim/_defaults.lua b/runtime/lua/vim/_defaults.lua
@@ -143,14 +143,16 @@ do
 
   vim.api.nvim_create_autocmd({ 'TermClose' }, {
     group = nvim_terminal_augroup,
+    nested = true,
     desc = 'Automatically close terminal buffers when started with no arguments and exiting without an error',
     callback = function(args)
-      if vim.v.event.status == 0 then
-        local info = vim.api.nvim_get_chan_info(vim.bo[args.buf].channel)
-        local argv = info.argv or {}
-        if #argv == 1 and argv[1] == vim.o.shell then
-          vim.cmd({ cmd = 'bdelete', args = { args.buf }, bang = true })
-        end
+      if vim.v.event.status ~= 0 then
+        return
+      end
+      local info = vim.api.nvim_get_chan_info(vim.bo[args.buf].channel)
+      local argv = info.argv or {}
+      if #argv == 1 and argv[1] == vim.o.shell then
+        vim.api.nvim_buf_delete(args.buf, { force = true })
       end
     end,
   })
diff --git a/test/functional/options/defaults_spec.lua b/test/functional/options/defaults_spec.lua
@@ -1232,3 +1232,22 @@ describe('stdpath()', function()
     end)
   end)
 end)
+
+describe('autocommands', function()
+  it('closes terminal with default shell on success', function()
+    api.nvim_set_option_value('shell', helpers.testprg('shell-test'), {})
+    command('set shellcmdflag=EXIT shellredir= shellpipe= shellquote= shellxquote=')
+
+    -- Should not block other events
+    command('let g:n=0')
+    command('au BufEnter * let g:n = g:n + 1')
+
+    command('terminal')
+    eq(eval('get(g:, "n", 0)'), 1)
+
+    helpers.retry(nil, 1000, function()
+      neq(api.nvim_get_option_value('buftype', { buf = 0 }), 'terminal')
+      eq(eval('get(g:, "n", 0)'), 2)
+    end)
+  end)
+end)