neovim

Neovim text editor
git clone https://git.dasho.dev/neovim.git
Log | Files | Refs | README

commit 4d654472e65ed28b7cd9e66c91d98b9991452266
parent 54f5602038975b28570f4ab183b3388842347f57
Author: Andreas Schneider <asn@cryptomilk.org>
Date:   Fri, 21 Apr 2023 11:30:31 +0200

fix(ui_client): check return code of dup()

gsrc/nvim/ui_client.c: In function ‘ui_client_start_server’:
gsrc/nvim/ui_client.c:68:5: warning: ignoring return value of ‘dup’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   68 |     dup(stderr_isatty ? STDERR_FILENO : STDOUT_FILENO);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Diffstat:
Msrc/nvim/ui_client.c | 6+++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/nvim/ui_client.c b/src/nvim/ui_client.c @@ -65,7 +65,11 @@ uint64_t ui_client_start_server(int argc, char **argv) #ifdef MSWIN os_open_conin_fd(); #else - dup(stderr_isatty ? STDERR_FILENO : STDOUT_FILENO); + int fd = dup(stderr_isatty ? STDERR_FILENO : STDOUT_FILENO); + if (fd < 0) { + return 0; + } + // FIXME: resource leak of fd #endif }