neovim

commit 46648c38677d6ad83a2b11d1cac14d9f185c62e5
parent 3a140ddbc62171451fb2f0b2f49bb38b1bc07f24
Author: György Andorka <gyorgy.andorka@protonmail.com>
Date:   Sat, 19 Jul 2025 03:40:16 +0200

fix(pack): close confirmation buffer's tabpage by ID #34971

Problem: On canceling the update (triggering `WinClosed`), the tab page
will most probably be closed too. Closing some other tab page while the
confirmation buffer is open also changes tab page numbers. We are trying
to close the wrong tab page in both cases.

Solution: save the tab page ID, and attempt to get the tab page number
from the ID when closing the buffer.
Diffstat:
M
runtime/lua/vim/pack.lua
 | 
6
++++--

1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/runtime/lua/vim/pack.lua b/runtime/lua/vim/pack.lua
@@ -783,12 +783,14 @@ local function show_confirm_buf(lines, on_finish)
   api.nvim_buf_set_name(bufnr, 'nvim-pack://' .. bufnr .. '/confirm-update')
   api.nvim_buf_set_lines(bufnr, 0, -1, false, lines)
   vim.cmd.sbuffer({ bufnr, mods = { tab = vim.fn.tabpagenr('#') } })
-  local tab_num = api.nvim_tabpage_get_number(0)
+  local tab_id = api.nvim_get_current_tabpage()
   local win_id = api.nvim_get_current_win()
 
   local delete_buffer = vim.schedule_wrap(function()
     pcall(api.nvim_buf_delete, bufnr, { force = true })
-    pcall(vim.cmd.tabclose, tab_num)
+    if api.nvim_tabpage_is_valid(tab_id) then
+      vim.cmd.tabclose(api.nvim_tabpage_get_number(tab_id))
+    end
     vim.cmd.redraw()
   end)