neovim

commit 3165e94a64b0b62a1d38b41969be57365dc516b6
parent 9f505b4d0f39c10dd4c5643a0d49cff25a3bb41b
Author: luukvbaal <luukvbaal@gmail.com>
Date:   Fri,  6 Jun 2025 12:40:57 +0200

fix(api): ensure win_get_config() "border" is reciprocal (#34322)

fix(api): ensure win_get_config() is reciprocal

Problem:  win_get_config() does not include a 'none' border field,
          causing nvim_open_win() to apply the 'winborder' value.
Solution: Include a 'none' border field in the returned config,
          such that it can be used reciprocally in nvim_open_win()
          to yield the same window layout.
Diffstat:
M
src/nvim/api/win_config.c
 | 
2
++
M
test/functional/ui/float_spec.lua
 | 
8
+++++---

2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/nvim/api/win_config.c b/src/nvim/api/win_config.c
@@ -768,6 +768,8 @@ Dict(win_config) nvim_win_get_config(Window window, Arena *arena, Error *err)
       if (config->footer) {
         config_put_bordertext(&rv, config, kBorderTextFooter, arena);
       }
+    } else {
+      PUT_KEY_X(rv, border, STRING_OBJ(cstr_as_string("none")));
     }
   } else if (!config->external) {
     PUT_KEY_X(rv, width, wp->w_width);
diff --git a/test/functional/ui/float_spec.lua b/test/functional/ui/float_spec.lua
@@ -1436,6 +1436,7 @@ describe('float window', function()
       local win = api.nvim_open_win(buf, false, { relative = 'editor', width = 20, height = 2, row = 3, col = 5, zindex = 60 })
       local expected = {
         anchor = 'NW',
+        border = 'none',
         col = 5,
         external = false,
         focusable = true,
@@ -1473,7 +1474,7 @@ describe('float window', function()
       if multigrid then
         api.nvim_win_set_config(win, { external = true, width = 10, height = 1 })
         eq(
-          { external = true, focusable = true, mouse = true, width = 10, height = 1, relative = '', hide = false },
+          { external = true, focusable = true, mouse = true, width = 10, height = 1, relative = '', hide = false, border = 'none' },
           api.nvim_win_get_config(win)
         )
       end
@@ -1923,7 +1924,7 @@ describe('float window', function()
       end
 
       api.nvim_win_set_config(win, { border = 'none' })
-      eq(nil, api.nvim_win_get_config(win).border)
+      eq('none', api.nvim_win_get_config(win).border)
 
       api.nvim_win_set_config(win, { border = { '', '', '', '>', '', '', '', '<' } })
       eq({ '', '', '', '>', '', '', '', '<' }, api.nvim_win_get_config(win).border)
@@ -4660,6 +4661,7 @@ describe('float window', function()
         height = 1,
         bufpos = { 1, 32 },
         anchor = 'NW',
+        border = 'none',
         hide = false,
         external = false,
         col = 0,
@@ -11443,7 +11445,7 @@ describe('float window', function()
 
       command('set winborder=none')
       winid = api.nvim_open_win(buf, true, config)
-      eq(nil, api.nvim_win_get_config(winid).border)
+      eq('none', api.nvim_win_get_config(winid).border)
       command('fclose!')
 
       -- respect config.border