commit 2c04ae9fcc9c9a70a7336d98e469ab6a5d97c6cc
parent 4998b8d7b5f948a6584ae44902001fb1c2bac95d
Author: SquallATF <squallatf@gmail.com>
Date: Wed, 19 Nov 2025 13:19:06 +0800
fix(windows): wrong RT_MANIFEST ID in nvim.rc #36406
Problem:
Starting Nvim on MinGW fails:
https://github.com/msys2/MINGW-packages/issues/25140
Unknown system error -1:"C:\msys64\ucrt64\bin\nvim.exe"Failed to start Nvim server!
Solution:
On Windows, the main application manifest should use resource ID 1 (RT_MANIFEST).
Update `nvim.rc` to use `1 RT_MANIFEST nvim.manifest` instead of `2`,
ensuring the manifest is correctly embedded and recognized by the system.
ID = 1 is for executable files (.exe)
ID = 2 is for DLLs (/DLL)
From MSVC docs: "Use a value of 2 for a DLL to enable it to specify private dependencies."
https://learn.microsoft.com/en-us/cpp/build/reference/manifest-create-side-by-side-assembly-manifest
Diffstat:
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/nvim/os/nvim.rc b/src/nvim/os/nvim.rc
@@ -1,2 +1,2 @@
#include "winuser.h"
-2 RT_MANIFEST nvim.manifest
+1 RT_MANIFEST nvim.manifest