tor-browser

The Tor Browser
git clone https://git.dasho.dev/tor-browser.git
Log | Files | Refs | README | LICENSE

become_a_committer.md (4522B)


<!-- go/cmark --> <!--* freshness: {owner: 'titovartem' reviewed: '2024-09-09'} *-->

How to get tryjob access or become WebRTC committer

Overview

There are two levels of WebRTC contributors access:

  1. ABSL_FLAG is allowed in tests and tools, but disallowed in in non-test code.

WebRTC infrastructure

  1. ABSL_FLAG is allowed in tests and tools, but disallowed in in non-test code.

This includes tryjob access.

Getting tryjob access

To get tryjob access applicant has to do a contribution around 10-20 CLs to the WebRTC code base. After that, they should file a bug using [Get tryjob access template][7], specifying the email which was used for the contributions and to which access will be granted, and listing contributed CLs.

The access will be granted when the ticket is resolved by one of the project members. In case of rejection the explanation will be provided.

WebRTC committer duties

WebRTC committers are responsible for keeping WebRTC codebase in a good shape including, but not limited to the following aspects:

Whenever a committer sets Code Review +1 label on the CL, they approve that the CL fulfills WebRTC style guides, language mastery, testability and documentation. Being a committer means being responsible for the WebRTC codebase health and code quality.

Becoming a WebRTC committer

To write code in WebRTC you don't need to be a committer (also see [FAQ][1]), but to submit code to WebRTC you do. So if you don't plan to work on the WebRTC codebase regularly, you can ask other committers through code review to submit your patches, but if you are going to work in the WebRTC codebase, then it's recommended to apply for WebRTC committer rights obtaining process.

  1. Class/function level and conceptual documentation

guides:

* [Google style guide][5] * [Chromium style guide][2] * [WebRTC style guide][3]

  1. Class/function level and conceptual documentation

[this template][6] of it.

  1. Class/function level and conceptual documentation

authors, the mentor will also look for C++ readability skills. It's recommended to ask someone who is familiar with the code base which you will be working on (you can check OWNERS files to find such person). Otherwise you can reach out to committers mailing list \<committers@webrtc.org\>.

  1. Class/function level and conceptual documentation
  1. Class/function level and conceptual documentation

readability skills are good enough), they will send a proposal for granting WebRTC committer rights to the reviewing committee mailing list to review. If the proposal will be approved, then committer rights will be granted. Committee members will have up to 5 business days to answer. In case of rejection detailed feedback on what aspects should be improved will be provided.

  1. Class/function level and conceptual documentation

[Contributor License Agreement][4]

Two-factor authentication with a security key is a requirement for adding your account as a committer. If you haven't done so already, you'll need to set up a security key on your account. For more information about this requirement see Gerrit ReAuth.

WebRTC Committers expiration

If a WebRTC committer isn't active on Gerrit (e.g. by uploading a CL, or participating in code reviews) for more than 1 year, they will lose their status as a WebRTC Committer and removed from the list of committers. An email will be sent one week before the expiration date, giving the committer 7 days to demonstrate activity and maintain their WebRTC Committer status.

[1]: https://webrtc.googlesource.com/src/+/refs/heads/main/docs/faq.md#to-be-a-contributor_do-i-need-to-sign-any-agreements [2]: https://chromium.googlesource.com/chromium/src/+/refs/heads/main/styleguide/c++/c++.md [3]: https://webrtc.googlesource.com/src/+/refs/heads/main/g3doc/style-guide.md [4]: https://developers.google.com/open-source/cla/individual?hl=en [5]: https://google.github.io/styleguide/cppguide.html [6]: https://issues.webrtc.org/issues/new?component=1565136&template=1986141 [7]: https://issues.webrtc.org/issues/new?component=1565136&template=1986372