cherry_picks.txt (7329B)
1 commit 419cd2c3213b594f8e2488bf48034fed20ace81d 2 Author: Shahbaz Youssefi <syoussefi@chromium.org> 3 Date: Mon Mar 27 13:05:36 2023 -0400 4 5 Translator: Initialize out arguments too for WebGL 6 7 Local variables were initialized for WebGL, but not `out` arguments. 8 However, `out` arguments completely overwrite the passed-in variable at 9 call site, so they should also be zeroed out. 10 11 Bug: chromium:1425685 12 Change-Id: Ib2f61a962eea74c4933aafa4d5ad377189cec578 13 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4375137 14 Reviewed-by: Geoff Lang <geofflang@chromium.org> 15 Reviewed-by: Kenneth Russell <kbr@chromium.org> 16 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> 17 18 commit 7918168436578718b234bfd56da152e34a85af1d 19 Author: Kelsey Gilbert <kelsey.gilbert@mozilla.com> 20 Date: Tue Jun 4 15:37:29 2024 -0700 21 22 Add GLSL variable byte size limits to ShBuiltInResources. 23 24 commit 31c0a5bff1330706aff3c4594c8166745814a45b 25 Author: Shahbaz Youssefi <syoussefi@chromium.org> 26 Date: Wed May 3 13:41:36 2023 -0400 27 28 WebGL: Limit total size of private data 29 30 ... not just individual arrays. 31 32 Bug: chromium:1431761 33 Change-Id: I721e29aeceeaf12c3f6a67b668abffb8dfbc89b0 34 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4503753 35 Reviewed-by: Kenneth Russell <kbr@chromium.org> 36 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> 37 38 commit ddaf44ac75d5d0390873c2af193e02159ecbe672 39 Author: Geoff Lang <geofflang@chromium.org> 40 Date: Fri Dec 8 13:20:36 2023 -0500 41 42 Validate Uniform variable limits with each iteration 43 44 VariablePacker would loop over all variables and sum up the total 45 row counts before validating. Each variable can take hundreds of rows 46 so it is possible to overflow the counters before validating them. 47 48 Validate the limits with each iteration and early-out when the limits 49 are exceeded. 50 51 https://bugzilla.mozilla.org/show_bug.cgi?id=1864587 52 53 Bug: chromium:1864587 54 Change-Id: Ic235ada1516a0d5a9948d82b22f6316a037c09ca 55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/5106408 56 Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> 57 Auto-Submit: Geoff Lang <geofflang@chromium.org> 58 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> 59 60 commit 6784271c1c6273a1be0b6a2dad9ac7b921521ad8 61 Author: Shahbaz Youssefi <syoussefi@chromium.org> 62 Date: Tue Mar 28 11:43:23 2023 -0400 63 64 Translator: Limit the size of private variables in WebGL shaders 65 66 As a follow up to 67 https://chromium-review.googlesource.com/c/angle/angle/+/3023033, the 68 limit to shader-private variables (locals and globals) is further 69 reduced to 1MB. A variable that large will not fit in GPU registers and 70 will spill to memory, killing performance. 71 72 Bug: chromium:1427865 73 Change-Id: I77314d4b891c591cd9a83ad2aebb77d7256f3ada 74 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4377639 75 Reviewed-by: Kenneth Russell <kbr@chromium.org> 76 77 commit 23347851217a581f3b9d877af203a0dcc4b7b6e9 78 Author: Kelsey Gilbert <kelsey.gilbert@mozilla.com> 79 Date: Wed Mar 29 16:13:39 2023 -0700 80 81 Add ShCompileOptions.initGLPointSize. 82 83 Change-Id: I1d998867f3e829ed0dc8181fa76be5fe701dde70 84 85 commit aa3a569c8ddc1122d55663749a6db63e48b3033c 86 Author: Ashley Hale <ahale@mozilla.com> 87 Date: Wed Mar 1 18:03:04 2023 -0800 88 89 Disable ClearView with scissor on Skylake iGPU because of observed bugs with edge corruption. (#27) 90 91 commit d93c05cd2d786f2c624fbf8f4465238b38a771a1 92 Author: Kelsey Gilbert <jgilbert@mozilla.com> 93 Date: Thu Sep 8 17:10:21 2022 -0700 94 95 Import <cmath> in SymbolTable_ESSL_autogen.cpp. 96 97 Fixes Snap builds of Firefox. 98 99 Change-Id: I8d71d230d5e4a5a042e6afd4e31342da9a085bed 100 101 Co-authored-by: Erich Gubler <erichdongubler@gmail.com> 102 103 commit 0bf5781fddeb50d02b703dd89cc77b2c5f07e334 104 Author: Erich Gubler <erichdongubler@gmail.com> 105 Date: Thu Jan 19 00:20:06 2023 -0500 106 107 build(linux): disable `PoolAlloc` to work around `asan` failures 108 109 We noticed this causing problems in [Firefox CI][failing-ci]. 110 111 [failing-ci]: https://treeherder.mozilla.org/jobs?repo=autoland&author=egubler%40mozilla.com&selectedTaskRun=e6KdZgnNTCOE9weaOnTjVQ.0 112 113 commit ea4d354f6cfc83c31446a855f3fd5603737eae76 114 Author: Erich Gubler <erichdongubler@gmail.com> 115 Date: Wed Nov 16 20:54:23 2022 -0500 116 117 fix(windows,pre-c++20): use default ctors for `std::atomic<angle::Mutex*>` 118 119 commit 9bcfaed62b60e210004217fd5e79c25f3e2b3760 120 Author: Jeff Gilbert <jdashg@gmail.com> 121 Date: Thu Jul 15 15:56:45 2021 -0700 122 123 Add missing header to build config. 124 125 commit 16baec7195df362b9d615ccb7e5d51673501e10e 126 Author: Jeff Gilbert <jdashg@gmail.com> 127 Date: Thu Feb 11 17:34:00 2021 -0800 128 129 Don't assert for non-sampleable non-ms sources in blitRenderbufferRect if we can CopySubResource. 130 131 In Firefox, we can have a source from DirectComposition without 132 D3D11_BIND_SHADER_RESOURCE. This is fine so long as our formats etc 133 match enough to hit the CopySubResource path. 134 Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1692355 135 136 commit 43e9d9a7c95b509869a774fab62bf42d6d15b745 137 Author: Jeff Muizelaar <jrmuizel@gmail.com> 138 Date: Wed May 6 14:04:42 2020 -0400 139 140 Don't use ClearView if we previously used dual source blending on Intel gen6. (#22) 141 142 Doing a ClearView after a dual source blend seems to cause a TDR on 143 Intel SandyBridge. Presumeably this is because the ClearView is 144 implemented as a regular draw and the driver doesn't properly set up the 145 state. 146 147 If we detect that this is going to happen we fall back to the manual 148 draw call path. This lets us use ClearView most of the time still. 149 150 commit b16ebaa05424354c06c2ccdccc36df2c7c1b191e 151 Author: Erich Gubler <erichdongubler@gmail.com> 152 Date: Wed Nov 9 21:12:44 2022 -0500 153 154 Fix broken build from `-Wexit-time-destructors` on Windows x64 155 156 commit 4c3a473aec4e09ffacd0466817cb851529087767 157 Author: Dzmitry Malyshau <dmalyshau@mozilla.com> 158 Date: Thu Dec 5 13:02:14 2019 -0500 159 160 Restrict the slow texture upload workaround to 128bit formats. (#21) 161 162 The workaround is slow for having a CPU-visible mirror of the texture, but that mirror is not properly recycled with regards to GPU usage, thus causing a CPU stall on update. 163 164 Original reports were related to WebRender vertex texture updates that are RGBA32F and RGBA32U formats. Limiting the workaround to these formats would allow the affected platforms to upload regular texture data faster without stalls. 165 166 Co-authored-by: Erich Gubler <erichdongubler@gmail.com> 167 168 Above: cherries picked 169 ================================================================================ 170 Below: merge base from: origin/chromium/5359 171 172 commit ceec659ac60b0c8ee9d9c602ca1a878ec1d3a88f 173 Author: Shahbaz Youssefi <syoussefi@chromium.org> 174 Date: Mon Oct 31 10:29:45 2022 -0400 175 176 M108: Vulkan: Disable logicOp dynamic state on Intel/Mesa 177 178 Hits a stack overflow inside the driver. 179 180 Bug: chromium:1379201 181 Change-Id: I790d7ef0333ba17eedbe91e4fc9c3a2b94563bff 182 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4004440 183 Reviewed-by: Yuxin Hu <yuxinhu@google.com>